canonical / canonical/react-components

Icon names in Icon props are out-of-date

Open
#1,188 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
151
Forks
74
Avg merge
1d 2h
Merged PRs (30d)
12

Description

The Icon component's props define a set of expected icon names here:
https://github.com/canonical/react-components/blob/60dd4449c266b6d3d08dbb9ec6d4a164162a3944/src/components/Icon/Icon.tsx#L7

However, this is out-of-date with the current state of Vanilla.

The following icons are missing (click to expand)


  • add-canvas

  • add-logical-volume

  • add-partition

  • applications

  • archive

  • arrow-bottom-left

  • arrow-bottom-right

  • arrow-down

  • arrow-left

  • arrow-right

  • arrow-top-left

  • arrow-top-right

  • arrow-up

  • back-to-top

  • begin-downloading

  • blueprint

  • book

  • bundle

  • canvas

  • certificate

  • certification

  • change-version

  • chevron-left

  • chevron-right

  • cluster-host

  • comments

  • conflict

  • conflict-grey

  • conflict-resolution

  • conflict-resolution-grey

  • connected

  • contact

  • containers

  • contextual-menu

  • controllers

  • copy-to-clipboard

  • credit-card

  • cursor

  • desktop

  • disconnect

  • edit

  • error-grey

  • export

  • exposed

  • file

  • file-blank

  • filter

  • folder

  • fork

  • fullscreen

  • get-link

  • gift

  • halfscreen-bar

  • heading

  • highlight-off

  • highlight-on

  • home

  • image

  • import

  • in-progress

  • inspector-debug

  • iso

  • loading-steps

  • location

  • lock-locked

  • lock-locked-active

  • lock-unlock

  • log-out

  • machines

  • map

  • maximise-bar

  • minimise-bar

  • models

  • mount

  • mount-2

  • notifications

  • open-terminal

  • pause

  • pin

  • plans

  • play

  • pods

  • power-error

  • power-off

  • power-on

  • priority-critical

  • priority-high

  • priority-low

  • priority-medium

  • priority-negligible

  • priority-unknown

  • private-key

  • profile

  • profiles

  • question

  • quote

  • repository

  • restart

  • revisions

  • security

  • security-error

  • security-tick

  • security-warning

  • select

  • select-add

  • select-remove

  • settings

  • single-host

  • snapshot

  • snooze

  • sort-both

  • sort-down

  • sort-up

  • starred

  • statistics

  • status

  • status-failed-small

  • status-in-progress

  • status-in-progress-small

  • status-queued

  • status-queued-small

  • status-succeeded-small

  • status-waiting

  • status-waiting-small

  • stop

  • submit-bug

  • success-grey

  • switcher

  • switcher-dashboard

  • switcher-environments

  • tag

  • task-outstanding

  • thumbs-down

  • thumbs-up

  • tidy

  • timed-out

  • timed-out-grey

  • toggle-side-nav

  • topic

  • turn-off-notification

  • unit-pending

  • unit-running

  • units

  • unmount

  • unstarred

  • upload

  • usb

  • user-group

  • video-play

  • warning-grey

  • website

This is quite a few missing icons, and the type currently allows for other strings to be passed in, so I'm not sure how high-priority it is to add these icons to the props.
https://github.com/canonical/react-components/blob/60dd4449c266b6d3d08dbb9ec6d4a164162a3944/src/components/Icon/Icon.tsx#L54

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.