canonical / canonical/multipass

No error handling in SSH session shutdown

Open
#4,963 0 comments 0 reactions 1 assignee Claimed by @ricab View on GitHub
jira
Dominant language
C++
Stars
9.2k
Forks
828
Avg merge
3d 1h
Merged PRs (30d)
44

Description

**Describe the bug**
PlainSSHSession's dtor lets exceptions through and `PlainSSHSession::force_shutdown` discards ::shutdown's return value and doesn't check for an invalid socket fd (-1), masking failures silently.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.