canonical / canonical/multipass

Move to a callback-based sftp server implementation

Open
#4,445 0 comments 0 reactions 1 assignee Claimed by @tobe2098 View on GitHub
needs triage
Dominant language
C++
Stars
9.2k
Forks
828
Avg merge
3d 2h
Merged PRs (30d)
43

Description

**What are you trying to do?**
When removing the libssh deprecation warnings, the sftp server initialization suggested to move to the callbacks-based server implementation. After some research, I have found in Gitlab the following libssh mirror that does implement an sample_sftpserver.c: https://gitlab.com/libssh/libssh-mirror/-/blob/master/examples/sample_sftpserver.c And in the PR they did they comment more on it.
I am unsure if this is a fork of our libssh or viceversa, but I think it would be nice to have this example.
Original PR that created example:
https://gitlab.com/libssh/libssh-mirror/-/merge_requests/263/diffs#cadf2ffbd25228d28ef40122660aa3c8ffb7d0d4
Merged PR:
https://gitlab.com/libssh/libssh-mirror/-/merge_requests/340/diffs

**What's your proposed solution?**
Modernize/refactor the sftp server implementation to be callback based.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.