canonical / canonical/multipass
Multipass daemon gets stuck if `vm->current_state()` throws
- Dominant language
- C++
- Stars
- 9.2k
- Forks
- 828
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 43
Description
Multipass daemon gets unresponsive if the `current_state()` call throws in the following code block:
https://github.com/canonical/multipass/blob/c3ec76c294e984bb344fb22aecae8761a3d522c0/src/daemon/daemon.cpp#L1391-L1393
The `current_state()` is not marked with `noexcept`, so handling the possible exception or marking the function as `noexcept` can mitigate the "stuck" situation.
Contributor guide
Research direction
Start in src/daemon/daemon.cpp at lines 1391-1393, where vm->current_state() is called. Review how exceptions from this call affect the daemon and determine whether the intended mitigation is exception handling or marking current_state() noexcept. Done means the daemon no longer becomes unresponsive when current_state() throws.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100