canonical / canonical/multipass
[windows] SSHFS does not deny access to folders that a user does not have permissions for
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 9.2k
- Forks
- 829
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 45
Description
**Describe the bug**
When creating an SMB mount, Multipass will check to see if the user has permissions for that folder and only create the mount if the user does. On the other hand, SSHFS mounts does not check and will create mounts to restricted directories.
**To Reproduce**
1. `multipass mount -t native C:\Windows\CSC\ foo:CSC_native`
2. `multipass mount C:\Windows\CSC\ foo:CSC`
**Expected behavior**
Both mounts should have the same behavior
**Logs**
Please provide logs from the daemon, see [accessing logs](https://multipass.run/docs/accessing-logs) on where to find them on your platform.
**Additional info**
- OS: `Windows`
- `multipass version`: `1.11`
- `multipass get local.driver`: `hyper-v`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two Windows commands against C:\Windows\CSC\ and compare the native SMB mount with the SSHFS mount. Start by tracing the mount permission checks for each path; done means both commands deny access to the restricted directory consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100