canonical / canonical/layer-basic
Makefile does not define tox lint tests correctly
- Dominant language
- Python
- Stars
- 10
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
When I run bundletester, I consistently get an error about flake8 not being found. I believe that this is because:
1) I evilly do not have flake8 installed in my global Python environment.
2) The Makefile in this layer incorrectly added the py34 and py35 tox virtual environments to its path.
Instead, the Makefile should add the "lint" virtual environment to its path, as below:
```
.PHONY: lint
lint: apt_prereqs
@tox --notest
@PATH=.tox/lint/bin flake8 $(wildcard hooks reactive lib unit_tests tests)
@charm proof
```
I am planning on submitting a patch for this soon -- wanted to record in case I get sidetracked, though.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.