canonical / canonical/layer-basic
Multiple calls to unitdata.kv().flush()
Open
- Dominant language
- Python
- Stars
- 10
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
charms.layer.basic.clear_config_states() calls unitdata.kv().flush(), which will be the second time the storage is flushed in the hook. In the perverse case where a failure happens between these two calls, we can end up with invalid state.
I think this is a use case for an actual `@cleanup` phase in charms.reactive, per https://github.com/juju-solutions/charms.reactive/pull/20
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.