canonical / canonical/layer-basic

Latest master doesn't have the basic hooks

Open
#128 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
10
Forks
42
PR merge metrics
No merged PRs in 30d

Description

It seems like the latest master remove the basic hooks from the hooks folder.

I saw the comment on the latest commit that affected the hooks folder:

> This also finishes the move to hook.template since `charm build` has
> supported binding from there for a while now.

Although, running `charm build` on my charm doesn't seem to create the hooks, but rather complains about the lack of hooks with the following output:

> [abso-magento1] proof: I: missing recommended hook install
> [abso-magento1] proof: I: missing recommended hook start
> [abso-magento1] proof: I: missing recommended hook stop
> [abso-magento1] proof: I: missing recommended hook config-changed

I'm not sure if it should've created the hooks automatically? or if I should copy the template and paste them into my charms?

I'm using charm-tools 2.2.3 for MacOS through Homebrew.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.