canonical / canonical/fpgad

Security: dbus: investigate and mitigate command injection

Open
#208 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
11
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Due to the way we are passing arguments along, we should be more careful in testing for side effects when a user tries to call dfx-mgr (or other future softeners).

I see a few tasks/options:
- see how much of an issue this is
- reimplement the dfx-mgr argument parser and require us to maintain it (burden) alongside dfx-mgr upstream
- add fuzz testing
- add side effect tests (try to get around the protections and create files or whatever other harmless, easily detected side effects can be produced and then test against them in future) whackamole style
- rely on an external crate or otherwise get experienced eyes on this

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how fpgad passes arguments to dfx-mgr and review the existing protections around that call; the issue names no files or tests. Reproduce harmless side effects to establish the current risk, then define completion as a mitigation with regression, fuzz, or side-effect test coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.