OpenStack detection broken on VMware

This bug was originally filed in Launchpad as [LP: #1788487](https://bugs.launchpad.net/cloud-init/+bug/1788487)

Launchpad details

affected_projects = ['cloud-init (Ubuntu)']

assignee = None

assignee_name = None

date_closed = None

date_created = 2018-08-22T20:22:57.619700+00:00

date_fix_committed = None

date_fix_released = None

id = 1788487

importance = medium

is_complete = False

lp_url = https://bugs.launchpad.net/cloud-init/+bug/1788487

milestone = None

owner = praseodym

owner_name = Mark

private = False

status = confirmed

submitter = praseodym

submitter_name = Mark

tags = []

duplicates = []

_Launchpad user **Mark(praseodym)** wrote on 2018-08-22T20:22:57.619700+00:00_

The OpenStack data source in cloud-init 18.3 was updated to detect OpenStack systems before probing the metadata endpoint. This broke for several cloud platforms (e.g. LP: #1784685) and is also broken for VMware.

As can be seen in LP: #1669875 there is no way to discern OpenStack on VMware from DMI data. A way around this could be to generally add 'VMware Virtual Platform' to the list of valid DMI platform names (`VALID_DMI_PRODUCT_NAMES`). This should still avoid the OpenStack metadata probe on most (if not all) other cloud platforms, as was the original goal in
https://git.launchpad.net/cloud-init/commit/?id=1efa8a0a030794cec68197100f31a856d0d264ab.