canonical / canonical/cloud-init

fs_config fails to set force flag

Open
#2,554 3 comments 0 reactions 0 assignees View on GitHub
bug launchpad
Dominant language
Python
Stars
3.8k
Forks
1.1k
Avg merge
2d 23h
Merged PRs (30d)
18

Description

This bug was originally filed in Launchpad as [LP: #1459464](https://bugs.launchpad.net/cloud-init/+bug/1459464)

Launchpad details

affected_projects = []

assignee = None
assignee_name = None
date_closed = None
date_created = 2015-05-27T23:51:01.553310+00:00
date_fix_committed = None
date_fix_released = None
id = 1459464
importance = undecided
is_complete = False
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1459464
milestone = None
owner = kevin-mm0v
owner_name = Kevin Tegtmeier
private = False
status = confirmed
submitter = kevin-mm0v
submitter_name = Kevin Tegtmeier
tags = []
duplicates = []

_Launchpad user **Kevin Tegtmeier(kevin-mm0v)** wrote on 2015-05-27T23:51:01.553310+00:00_

It looks like the force flag is never appended because fs_cmd is always set:

http://bazaar.launchpad.net/~cloud-init-dev/cloud-init/trunk/view/head:/cloudinit/config/cc_disk_setup.py#L843

It is probably safe to change
if not fs_cmd and (overwrite or device_type(device) == "disk"):
to
if overwrite:

(not sure how the device_type(device) == disk helps us here- maybe this should be an and instead of or?).

Thanks,

Kevin

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.