canonical / canonical/authd

e2e-tests: Entra password tests don't retry on expired TOTP

Open
#1,698 1 comment 0 reactions 0 assignees View on GitHub
e2e-tests
Dominant language
Go
Stars
308
Forks
41
Avg merge
2d 4h
Merged PRs (30d)
58

Description

When using TOTP, it can always happen that the code expires between generation and entering. The tests should handle that case by retrying with a fresh TOTP code. The Entra password tests currently don't do that.

This occurred in:
* https://authd-e2e-test-logs.adrian-dombeck.workers.dev/push-33780608239/run-33780608239-1/resolute-authd-msentraid/log.html#s1-s17-t2
* https://authd-e2e-test-logs.adrian-dombeck.workers.dev/push-33863989467/run-33863989467-1/resolute-authd-msentraid/log.html#s1-s17
* https://authd-e2e-test-logs.adrian-dombeck.workers.dev/push-33891271000/run-33891271000-1/resolute-authd-msentraid/log.html#s1-s17
* https://authd-e2e-test-logs.adrian-dombeck.workers.dev/pr-1614/run-28933038903-1/resolute-authd-msentraid/log.html#s1-s15

Image

Image

Contributor guide

Open the contributing guide

Research direction

Start by locating the Entra password end-to-end tests in the authd repository and review the linked failure logs for the expired-TOTP path. Run the relevant Entra password test to reproduce the timing failure; done means an expired code causes a fresh TOTP code to be generated and the test retries successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.