cancervariants / cancervariants/gene-normalization

Clean up DB interface elements

Open
#294 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
3
Forks
4
PR merge metrics
No merged PRs in 30d

Description

* `create_db` -> `get_db` or `get_db_connection`
* `gene.database.database` gives `from datetime import datetime vibes`. not desirable.
* Can we rename `DynamoDbDatabase` to `DynamoDb` or `DynamoDatabase`? I think it was done to be consistent with child class names ending in Database, but seems redundant to have db and database in the name
* Change URL environment variable?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the database interface definitions and references to `create_db`, `gene.database.database`, `DynamoDbDatabase`, and the URL environment variable. Review how these names are used across the repository before deciding the consistent replacements; the work is done when the agreed naming and environment-variable changes are applied without broken references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.