cameron314 / cameron314/readerwriterqueue
Deprecation warning when building with recent versions of CMake
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 4.6k
- Forks
- 736
- Avg merge
- 10d 5h
- Merged PRs (30d)
- 1
Description
First, thanks for a great library!
Issue
When building with a recent version of CMake (3.31.7) I see the following warning:
build>cmake ..
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
-- The C compiler identification is Clang 20.1.7
-- The CXX compiler identification is Clang 20.1.7
-- Detecting...
I think CMake is complaining that the readerwriterqueue project:
- declares a requirement of CMake 3.9 or better, but
- does not explicitly declare compatibility with more recent versions of CMake than 3.9,...
- and CMake 3.9 will cease to be supported soon.
Seems like the easiest thing to do is just bump the minimum required version to v3.10?
I'd be happy submit a PR that does this?
Regards,
Jonathon
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at CMakeLists.txt line 1 and reproduce the warning with the reported cmake .. command from a build directory using a recent CMake version. Check the project’s declared minimum version and compatibility behavior; done means the deprecation warning is gone while the project still configures successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100