cameron314 / cameron314/concurrentqueue
Consider not making functions in headers static to improve compatibility with C++ modules
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 12.5k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Description
If a function is marked static, the header put into the global fragment and a template ends up causing instantiation and thus call of this static function, well, with modules this does not work.
Here's a patch : https://github.com/cameron314/concurrentqueue/commit/324c8187e294a78618c99d19dd7cd43809784333
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the header functions marked static and compare their treatment with the patch at commit 324c8187e294a78618c99d19dd7cd43809784333. Verify that the resulting headers remain compatible with C++ modules, including template instantiation and calls to those functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100