camelot-dev / camelot-dev/excalibur

UI-created rules set row_close_tol vs. row_tol, col_close_tol vs. col_tol

Open Beginner friendly
#131 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.8k
Forks
238
PR merge metrics
No merged PRs in 30d

Description

Just downloaded and installed latest release.

I have found that if I set the group row tolerance in the text box in the UI, it doesn't seem to do anything.

I downloaded the JSON for the saved rule, and saw the key is called row_close_tol. Apparently it should be row_tol as in the advanced docs.

If I edit the JSON to have row_tol as the key and upload it in Rules, then apply the rule, this feature works properly.

The UI-created rule also sets col_close_tol vs. col_tol.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how the UI saves and downloads rules, then compare the row and column tolerance keys with the advanced documentation and the upload/apply path. Update the UI-created rule keys so the configured tolerances are honored, and verify that saving, downloading, re-uploading, and applying a rule preserves the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.