callstack / callstack/react-native-paper

Menu component closes and fails to open again on re-render

Open
#4,763 26 comments 15 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
14.5k
Forks
2.2k
Avg merge
5d 23h
Merged PRs (30d)
12

Description

### Current behaviour
- Open the Menu component
- The parent component re-renders
- Menu component closes and can't be opened again

### Expected behaviour
- Open the Menu component
- The parent component re-renders
- Menu component stays open

### How to reproduce?
```TSX
import React, {useState} from 'react';
import {View} from 'react-native';
import {Button, Menu, PaperProvider} from 'react-native-paper';

const MyComponent = () => {
const [randomVarialbeToForceRerender, setRandomVarialbeToForceRerender] =
useState(0);
const [visible, setVisible] = useState(false);

const openMenu = () => {
console.debug('Opening menu');
setVisible(true);

/**
* We update a state variable to force a re-render of the component.
* A real-world example could be a network request or some other
* asynchronous operation that updates the state.
*/
setTimeout(() => setRandomVarialbeToForceRerender(Math.random()), 1000);
};

const closeMenu = () => {
setVisible(false);
console.debug('Closing menu');
};

console.debug('visible', visible);
return (


Show menu}>
{}}
title={`Random ${randomVarialbeToForceRerender}`}
/>



);
};

export default MyComponent;
```

### Preview
https://github.com/user-attachments/assets/3d995026-ab4e-4fd3-bbf3-5544164a63ec

### What have you tried so far?
Memoization to avoid re-rendering the menu. However, this approach is limited and breaks
when the menu items are non-static (c.f. example)

### Your Environment

| software | version
| --------------------- | -------
| ios | 18.5
| android | x
| react-native | 0.77.2
| react-native-paper | 5.13.1
| node | 18.20.8
| npm or yarn | 3.8.7
| expo sdk | x.x.x

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.