callstack / callstack/react-native-paper

Why `paddingHorizontal: Math.max(left, right)` in AppbarHeader ?

Open
#4,535 1 comment 0 reactions 0 assignees View on GitHub
Appbar question
Dominant language
TypeScript
Stars
14.5k
Forks
2.2k
Avg merge
5d 23h
Merged PRs (30d)
12

Description

AppBar cannot align with content when screen orientation locked `LANDSCAPE_LEFT`

CleanShot 2024-10-25 at 23 11 27@2x

When orientation locked `LANDSCAPE_RIGHT`, align is ok.

CleanShot 2024-10-25 at 23 11 58@2x

---

Why Math.max ? It seems to be intentional, or may be a bug ?

https://github.com/callstack/react-native-paper/blob/9162a1fdf4e97c0669de8a8fa2057d8cfbe2e728/src/components/Appbar/AppbarHeader.tsx#L140C11-L140C52

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.