callstack / callstack/agent-device
fix(ios): distinct lineage for in-place system-surface captures (verify/settle)
- Dominant language
- TypeScript
- Stars
- 4.6k
- Forks
- 299
- Avg merge
- 10h 17m
- Merged PRs (30d)
- 515
Description
Follow-up to #2438 / #2448.
**Purpose.** A capture served from a system surface (SafariViewService sheet) must not be comparable to an app-baseline capture, or `--verify`/`--settle` could diff a sheet against the app and misreport.
**Required behavior.** Carry the runner's `systemSurface` provenance into the iOS snapshot `comparisonIdentity`/lineage so a system-surface capture and an app capture are never treated as the same presentation. Post-tap corroboration (`hasMatchingPresentation`) and `--settle` diffs must refuse to compare across the app↔sheet boundary.
**Observable completion.** A `--settle`/`--verify` around an interaction that crosses into or out of the sheet does not produce a spurious diff; a unit test pins the identity mismatch.
**Dependencies.** #2448 already threads `systemSurface` through `readAppleSnapshotResult`; this wires it into lineage. See Fable rule 5 in the #2448 ADR amendment.
Contributor guide
Assessment
This issue has not been assessed yet.