Adapter should not depend on MigrationInterface
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
The AdapterInterface violates the separation as it knows about the MigrationInteface in the migrated method.
We are for example using phinx´ adapter structure but have a slightly different MigrationInterface ( no downs ) and different Manager (Module-specific)
Currently we need to "hack" the migrated function, even though there does not come any MigrationInterace in... So this "migrated" thing should be in the Manager, not in the Adapter
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing AdapterInterface::migrated and its references to MigrationInterface, then compare how the Manager handles migration state. Review the adapter and manager abstractions to determine the appropriate ownership of this behavior. Done means adapters no longer depend on MigrationInterface and the existing migration flow remains functional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100