SqlServerAdapter::getColumns returns associative array
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
The SqlServerAdapter::getColumns function returns an associative array of columns, where the keys are column names. All other adapters return a numeric array which is also expressed by our AdapterInterface:
The SqlServerAdapter::getColumns method should be changed to return numeric array. As this is public facing functionality, this will require a major release.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/Phinx/Db/Adapter/SqlServerAdapter.php at SqlServerAdapter::getColumns, then compare its return contract with AdapterInterface.php and the other adapters. Confirm the expected numeric-array shape and check the relevant adapter tests if available. Done means the SQL Server adapter matches the interface and the public API change is accounted for in the major-release note.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100