SQL Server adapter still uses text and ntext types, despite deprecation
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
According to MS's documentation for SQL Server 2017, ntext and text are deprecated and pending removal. It has been official guidance to use varchar(max) and nvarchar(max) for years instead of these types.
The use of these old types also requires SQL to be written to cast or convert when comparing strings, further encouraging the need for this to be changed.
The adapter should be changed to generate varchar(max) and nvarchar(max) instead of text and ntext.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SQL Server adapter and its type mapping for text and ntext. Verify how the adapter generates schema SQL, then confirm that the generated types use varchar(max) and nvarchar(max) instead and add or update coverage if an existing adapter test is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, sql
- Domain
- database
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100