Should not the quoteString method be public
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/cakephp/phinx/blob/877033d6e44d60f8ff149fa9f57f135a33fbbff6/src/Phinx/Db/Adapter/PdoAdapter.php#L283
Currently the quoteString method exists, but it is protected, making it impossible to use in migrations. Is there anything what stops it being public?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Phinx/Db/Adapter/PdoAdapter.php at the protected quoteString method around line 283, and inspect how migrations access adapter methods. Determine whether making it public is compatible with the surrounding API; done means migrations can call quoteString directly without breaking existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100