Handle secrets from files
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
Docker encourages the use of files for secrets. I always make my PDO class compatible with phinx environments as far as possible. I recently added:
$password = $password ?? $config['pass'] ?? trim(get_file_contents($config['pass_file']));
I wondered whether phinx might be interested in doing likewise?
K.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no repository files or tests. Start by locating how Phinx reads the pass database configuration and how environments are resolved, then compare that path with the proposed pass_file behavior. Done means file-based secrets are accepted without breaking existing password configuration, with coverage for the new configuration form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100