changeColumn() allow null
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 4.5k
- Forks
- 884
- PR merge metrics
- No merged PRs in 30d
Description
$this->changeColumn('website', null, ['default'=>'null'])
This should keep the column type as is but just makes it null-able. Right now you have to specify the current column type for 2nd parameter even if its not changing. I should make it so that passing empty string or null keeps it as is.
Its also finicky about 'default' being set to the string 'null' and not the actual value null.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the changeColumn() implementation and read how its second argument and the default option are handled. The change is done when an empty string or null preserves the existing column type, and a null default is handled consistently without requiring the string 'null'.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100