cake-build / cake-build/cake

Improve FilePathCollection usage

Open
#2,926 0 comments 0 reactions 0 assignees View on GitHub
Improvement
Dominant language
C#
Stars
4.2k
Forks
778
Avg merge
1h 15m
Merged PRs (30d)
19

Description

Hello!

First of all, thanks for this awesome project!

So, I want to request a very small feature that will make the usage of FilePathCollection better.
I have noticed that despite having this class, it seems that you use ICollection\ for everything.
I've runned in this in the AzurePipelinesPublishTestResultsData where I want to use the GetFiles to get all *.trx files and set it in the TestResultsFiles property, but I can't do it directly because it accepts ICollection\ and FilePathCollection despite the name doesn't implement it.

An easier way to do it would probably just be to implement the implicit operator.

What do you guys think?

Thanks!

Contributor guide

Open the contributing guide

Research direction

Start by locating FilePathCollection and AzurePipelinesPublishTestResultsData, then inspect how TestResultsFiles currently accepts ICollection. The issue is done when FilePathCollection can be used directly for that property through the proposed conversion, with corresponding behavior covered by the project’s tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.