cake-build / cake-build/cake

Passing any Path to MSBuild, not just FilePath

Open
#2,159 0 comments 0 reactions 0 assignees View on GitHub
Improvement
Dominant language
C#
Stars
4.2k
Forks
778
Avg merge
1h 15m
Merged PRs (30d)
19

Description

It's fairly rare for me to want to specify a file path for MSBuild. Usually the path which shows most clearly what I really care about is either `"."` or `"ProjectDir"`.

```cs
var someProjectDir = Directory("SomeProject");

// ...

MSBuild(someProjectDir, …);
```

The error this causes:

> error CS1503: Argument 1: cannot convert from 'Cake.Common.IO.Paths.ConvertableDirectoryPath' to 'Cake.Core.IO.FilePath'

If we change the first parameter of the MSBuild alias to `Path` instead of `FilePath`, would passing a `ConvertableDirectoryPath` just work?
Would you accept a PR for this? 😃

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.