Cake causes warning by trying to load addin dependency

(From https://github.com/AMVSoftware/Cake.SqlServer/issues/18)

Cake tries to load and reference every DLL in the Cake.SqlServer addin which results in this warning every time:

Could not load tools\Addins\Cake.SqlServer\lib\net45\Microsoft.Data.Tools.Schema.Sql.dll (missing Microsoft.SqlServer.TransactSql, Version=13.0.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91)

When it comes to actually using it, if I call the alias CreateBacpacFile, it runs Microsoft.SqlServer.Dac.dll which runs Microsoft.Data.Tools.Schema.Sql.dll just fine. It's a critical DLL which is needed by the addin DLL, so it can't be left out of the package. The only problem is when Cake tries to reference the DLL directly.

I have no idea what is causing this. Perhaps something was ILMerged?

In any case it's probably a waste for Cake to be trying to reference this DLL for the script. As far as I can tell, the only DLL that the script needs to directly reference is the addin DLL itself.
It would be nice if there was a way for addin authors to specify a list of DLLs to reference and only reference all DLLs if they haven't taken the time to specify which DLLs actually contain addins. This is exactly the way https://docs.microsoft.com/en-us/nuget/schema/nuspec#explicit-assembly-references works.

Steps to reproduce:

• Create build.cake with these contents:

  #addin Cake.SqlServer
  

• Run tools\Cake\cake.exe build.cake

Output:

Could not load C:\Users\Joseph\Desktop\test\tools\Addins\Cake.SqlServer\lib\net45\Microsoft.Data.Tools.Schema.Sql.dll (missing Microsoft.SqlServer.TransactSql, Version=13.0.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91)

• Run tools\Cake\cake.exe build.cake --verbosity=diagnostic

Output:

Module directory does not exist.
Analyzing build script...
Analyzing C:/Users/Joseph/Desktop/test/build.cake...
Processing build script...
Installing addins...
Package Cake.SqlServer has already been installed.
The addin Cake.SqlServer will reference Cake.SqlServer.dll.
The addin Cake.SqlServer will reference Microsoft.Data.Tools.Schema.Sql.dll.
The addin Cake.SqlServer will reference Microsoft.Data.Tools.Utilities.dll.
The addin Cake.SqlServer will reference Microsoft.SqlServer.Dac.dll.
The addin Cake.SqlServer will reference Microsoft.SqlServer.Dac.Extensions.dll.
The addin Cake.SqlServer will reference Microsoft.SqlServer.TransactSql.ScriptDom.dll.
The addin Cake.SqlServer will reference Microsoft.SqlServer.Types.dll.
Creating script session...
Could not load file or assembly 'Microsoft.SqlServer.TransactSql, Version=13.0.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91' or one of its dependencies. The system cannot find the file specified.
Fusion Log:
WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].


Could not load file or assembly 'Microsoft.SqlServer.TransactSql, Version=13.0.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91' or one of its dependencies. The system cannot find the file specified.
Fusion Log:
WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].


Could not load C:\Users\Joseph\Desktop\test\tools\Addins\Cake.SqlServer\lib\net45\Microsoft.Data.Tools.Schema.Sql.dll (missing Microsoft.SqlServer.TransactSql, Version=13.0.0.0, Culture=neutral, PublicKeyToken=89845dcd8080cc91)
Adding reference to mscorlib.dll...
Adding reference to System.Core.dll...
Adding reference to Cake.Core.dll...
Adding reference to Cake.Common.dll...
Adding reference to Cake.exe...
Adding reference to System.dll...
Adding reference to System.Xml.dll...
Adding reference to System.Xml.Linq.dll...
Adding reference to System.Data.dll...
Adding reference to Cake.SqlServer.dll...
Adding reference to Microsoft.Data.Tools.Schema.Sql.dll...
Adding reference to Microsoft.Data.Tools.Utilities.dll...
Adding reference to Microsoft.SqlServer.Dac.dll...
Adding reference to Microsoft.SqlServer.Dac.Extensions.dll...
Adding reference to Microsoft.SqlServer.TransactSql.ScriptDom.dll...
Adding reference to Microsoft.SqlServer.Types.dll...
Importing namespace Cake.Common...
Importing namespace Cake.Common.Build...
Importing namespace Cake.Common.Build.AppVeyor...
Importing namespace Cake.Common.Build.AppVeyor.Data...
Importing namespace Cake.Common.Build.Bamboo...
Importing namespace Cake.Common.Build.Bamboo.Data...
Importing namespace Cake.Common.Build.BitbucketPipelines...
Importing namespace Cake.Common.Build.BitbucketPipelines.Data...
Importing namespace Cake.Common.Build.Bitrise...
Importing namespace Cake.Common.Build.Bitrise.Data...
Importing namespace Cake.Common.Build.ContinuaCI...
Importing namespace Cake.Common.Build.ContinuaCI.Data...
Importing namespace Cake.Common.Build.GitLabCI...
Importing namespace Cake.Common.Build.GitLabCI.Data...
Importing namespace Cake.Common.Build.GoCD...
Importing namespace Cake.Common.Build.GoCD.Data...
Importing namespace Cake.Common.Build.Jenkins...
Importing namespace Cake.Common.Build.Jenkins.Data...
Importing namespace Cake.Common.Build.MyGet...
Importing namespace Cake.Common.Build.TeamCity...
Importing namespace Cake.Common.Build.TFBuild...
Importing namespace Cake.Common.Build.TFBuild.Data...
Importing namespace Cake.Common.Build.TravisCI...
Importing namespace Cake.Common.Build.TravisCI.Data...
Importing namespace Cake.Common.Diagnostics...
Importing namespace Cake.Common.IO...
Importing namespace Cake.Common.IO.Paths...
Importing namespace Cake.Common.Net...
Importing namespace Cake.Common.Security...
Importing namespace Cake.Common.Solution...
Importing namespace Cake.Common.Solution.Project...
Importing namespace Cake.Common.Solution.Project.Properties...
Importing namespace Cake.Common.Solution.Project.XmlDoc...
Importing namespace Cake.Common.Text...
Importing namespace Cake.Common.Tools...
Importing namespace Cake.Common.Tools.Cake...
Importing namespace Cake.Common.Tools.Chocolatey...
Importing namespace Cake.Common.Tools.Chocolatey.ApiKey...
Importing namespace Cake.Common.Tools.Chocolatey.Config...
Importing namespace Cake.Common.Tools.Chocolatey.Features...
Importing namespace Cake.Common.Tools.Chocolatey.Install...
Importing namespace Cake.Common.Tools.Chocolatey.New...
Importing namespace Cake.Common.Tools.Chocolatey.Pack...
Importing namespace Cake.Common.Tools.Chocolatey.Pin...
Importing namespace Cake.Common.Tools.Chocolatey.Push...
Importing namespace Cake.Common.Tools.Chocolatey.Sources...
Importing namespace Cake.Common.Tools.Chocolatey.Uninstall...
Importing namespace Cake.Common.Tools.Chocolatey.Upgrade...
Importing namespace Cake.Common.Tools.DotCover...
Importing namespace Cake.Common.Tools.DotCover.Analyse...
Importing namespace Cake.Common.Tools.DotCover.Cover...
Importing namespace Cake.Common.Tools.DotCover.Merge...
Importing namespace Cake.Common.Tools.DotCover.Report...
Importing namespace Cake.Common.Tools.DotNetCore...
Importing namespace Cake.Common.Tools.DotNetCore.Build...
Importing namespace Cake.Common.Tools.DotNetCore.Execute...
Importing namespace Cake.Common.Tools.DotNetCore.Pack...
Importing namespace Cake.Common.Tools.DotNetCore.Publish...
Importing namespace Cake.Common.Tools.DotNetCore.Restore...
Importing namespace Cake.Common.Tools.DotNetCore.Run...
Importing namespace Cake.Common.Tools.DotNetCore.Test...
Importing namespace Cake.Common.Tools.DupFinder...
Importing namespace Cake.Common.Tools.Fixie...
Importing namespace Cake.Common.Tools.GitLink...
Importing namespace Cake.Common.Tools.GitReleaseManager...
Importing namespace Cake.Common.Tools.GitReleaseManager.AddAssets...
Importing namespace Cake.Common.Tools.GitReleaseManager.Close...
Importing namespace Cake.Common.Tools.GitReleaseManager.Create...
Importing namespace Cake.Common.Tools.GitReleaseManager.Export...
Importing namespace Cake.Common.Tools.GitReleaseManager.Publish...
Importing namespace Cake.Common.Tools.GitReleaseNotes...
Importing namespace Cake.Common.Tools.GitVersion...
Importing namespace Cake.Common.Tools.ILMerge...
Importing namespace Cake.Common.Tools.ILRepack...
Importing namespace Cake.Common.Tools.InnoSetup...
Importing namespace Cake.Common.Tools.InspectCode...
Importing namespace Cake.Common.Tools.MSBuild...
Importing namespace Cake.Common.Tools.MSTest...
Importing namespace Cake.Common.Tools.NSIS...
Importing namespace Cake.Common.Tools.NuGet...
Importing namespace Cake.Common.Tools.NuGet.Add...
Importing namespace Cake.Common.Tools.NuGet.Init...
Importing namespace Cake.Common.Tools.NuGet.Install...
Importing namespace Cake.Common.Tools.NuGet.Pack...
Importing namespace Cake.Common.Tools.NuGet.Push...
Importing namespace Cake.Common.Tools.NuGet.Restore...
Importing namespace Cake.Common.Tools.NuGet.SetApiKey...
Importing namespace Cake.Common.Tools.NuGet.SetProxy...
Importing namespace Cake.Common.Tools.NuGet.Sources...
Importing namespace Cake.Common.Tools.NuGet.Update...
Importing namespace Cake.Common.Tools.NUnit...
Importing namespace Cake.Common.Tools.OctopusDeploy...
Importing namespace Cake.Common.Tools.OpenCover...
Importing namespace Cake.Common.Tools.ReportGenerator...
Importing namespace Cake.Common.Tools.ReportUnit...
Importing namespace Cake.Common.Tools.Roundhouse...
Importing namespace Cake.Common.Tools.SignTool...
Importing namespace Cake.Common.Tools.SpecFlow...
Importing namespace Cake.Common.Tools.SpecFlow.StepDefinitionReport...
Importing namespace Cake.Common.Tools.SpecFlow.TestExecutionReport...
Importing namespace Cake.Common.Tools.TextTransform...
Importing namespace Cake.Common.Tools.VSTest...
Importing namespace Cake.Common.Tools.VSWhere...
Importing namespace Cake.Common.Tools.VSWhere.All...
Importing namespace Cake.Common.Tools.VSWhere.Latest...
Importing namespace Cake.Common.Tools.VSWhere.Legacy...
Importing namespace Cake.Common.Tools.VSWhere.Product...
Importing namespace Cake.Common.Tools.WiX...
Importing namespace Cake.Common.Tools.WiX.Heat...
Importing namespace Cake.Common.Tools.XBuild...
Importing namespace Cake.Common.Tools.XUnit...
Importing namespace Cake.Common.Xml...
Importing namespace Cake.Core...
Importing namespace Cake.Core.Diagnostics...
Importing namespace Cake.Core.IO...
Importing namespace Cake.Core.Scripting...
Importing namespace Cake.SqlServer...
Importing namespace System...
Importing namespace System.Collections.Generic...
Importing namespace System.IO...
Importing namespace System.Linq...
Importing namespace System.Text...
Importing namespace System.Threading.Tasks...
Compiling build script...

Reproduce the issue with build.cake containing #addin Cake.SqlServer, using tools\Cake\cake.exe and diagnostic verbosity. Then trace the addin installation and reference-loading entry point that enumerates the package DLLs. Done means the missing dependency no longer produces a warning or direct-reference failure while CreateBacpacFile still works.