NugetPush fails when ApiKey contains a special character
- Dominant language
- C#
- Stars
- 4.2k
- Forks
- 778
- Avg merge
- 3h 37m
- Merged PRs (30d)
- 21
Description
### What You Are Seeing?
NugetPush fails when the apikey contains a special character like the Escape Character ^
### What is Expected?
Cake.Common.Tools.NuGet.Push.NuGetPusher.cs should probably use a QuotedArgument here: https://github.com/cake-build/cake/blob/08907d1a5d97b66f58c01ae82506280882dcfacc/src/Cake.Common/Tools/NuGet/Push/NuGetPusher.cs#L72
### What version of Cake are you using?
0.17
### Are you running on a 32 or 64 bit system?
64bit
### What environment are you running on? Windows? Linux? Mac?
Windows 10
### Are you running on a CI Server? If so, which one?
No
### How Did You Get This To Happen? (Steps to Reproduce)
My password contains a ^ character and I kept getting back a 401
Contributor guide
Research direction
Start by inspecting src/Cake.Common/Tools/NuGet/Push/NuGetPusher.cs at the referenced line, focusing on how the API key is passed to NuGet. Reproduce the Windows failure with an API key containing ^, then verify that NuGet push succeeds with that key.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100