cake-build / cake-build/cake-vscode

Command "add addin|tool|module from NuGet" removes additional query params

Open
#554 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
45
Forks
28
PR merge metrics
No merged PRs in 30d

Description

Given the following setup:
![image](https://user-images.githubusercontent.com/349188/120759179-0b536f80-c513-11eb-857d-b9670fd78b1a.png)

(Notice how version and package are "switched" in `Cake.7zip`)

When I run the "add addin from NuGet" command and re-select `Cake.7zip` (i.e. to update the version), the line will look like this:
![image](https://user-images.githubusercontent.com/349188/120759338-3938b400-c513-11eb-93cd-638996df6be1.png)

(Notice how package and version now follow the "usual" ordering).
Which is fine for me. (Not 100% optimal, but "ok".)

However, is the setup would be something like:
![image](https://user-images.githubusercontent.com/349188/120759530-62f1db00-c513-11eb-8f25-fef87b271f5d.png)

after re-running the command, the line will look like this:
![image](https://user-images.githubusercontent.com/349188/120759338-3938b400-c513-11eb-93cd-638996df6be1.png)

Which is a problem, when the additional params were needed for something. (I.e. if one of the additional params was `loaddependencies=true`...)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the "add addin|tool|module from NuGet" command with a package entry containing additional query parameters such as loaddependencies=true. Trace the command's NuGet entry handling to find where the entry is rewritten; done means updating the package or version preserves all existing query parameters.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.