caddyserver / caddyserver/certmagic

Make field names consistent

Open
#302 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

discussion
Dominant language
Go
Stars
5.6k
Forks
354
Avg merge
9d 23h
Merged PRs (30d)
3

Description

"challenge" vs. "challenge_type"... "identifier" vs. "identifiers"... etc.

For identifier/identifiers, we might need to make them all plural (arrays, even if only 1?) or for some of them perhaps users will just have to query like identifier = X OR contains(identifiers, X)... I dunno.

Using consistent field names make querying easier overall.

(Feedback from a sponsor.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the public fields represented by the examples “challenge”/“challenge_type” and “identifier”/“identifiers,” then determine whether singular values should become arrays or require separate query handling. Done means the naming policy is decided and applied consistently across the affected fields, with querying behavior documented or covered by the relevant checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.