Missing German translations in incident.php
- Dominant language
- PHP
- Stars
- 227
- Forks
- 84
- Avg merge
- 11h 14m
- Merged PRs (30d)
- 24
Description
Hello everybody,
after installing cachet 3x and using following environment variables
APP_LOCALE = de
APP_FALLBACK_LOCALE = de
APP_FAKER_LOCALE = de_DE
cachet::incident.timeline.from_label
and
cachet::incident.timeline.to_label
are shown instead of the correct German translation.
A possible fix is to add from_label and to_label below line 20 in vendor/cachethq/core/resources/lang/de/incident.php:
20 'no_incidents_reported_between' => 'Keine Vorfälle gemeldet zwischen :from und :to',
21 'from_label' => 'Von',
22 'to_label' => 'Bis',
23 'navigate' => [
24 'previous' => 'Vor',
[changes.patch](https://github.com/user-attachments/files/31861528/changes.patch)
Best regards
Alexander
Contributor guide
Research direction
Start with vendor/cachethq/core/resources/lang/de/incident.php and compare its incident timeline keys with the labels referenced in the issue. Add the German entries for from_label and to_label, then verify the incident timeline displays “Von” and “Bis” when APP_LOCALE and APP_FALLBACK_LOCALE are set to de.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- laravel, php
- Domain
- localization
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100