cabaletta / cabaletta/baritone

Water is not picked up after Bucket Fall

Open
#1,698 3 comments 4 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
9.2k
Forks
2.1k
Avg merge
4d 3h
Merged PRs (30d)
3

Description

## Some information
Minecraft version: 1.12.2
Baritone version: standalone-forge-1.2.14

## Exception, error or logs
Nothing is written to log

## How to reproduce
Start a path that involves a water bucket fall
Water bucket will not be picked up

This does not occur 100% of the time, sometimes it is picked up. I've noticed this while travelling in the end. I didnt notice any pattern that would hint why it would/wouldnt be picked up.

After looking at the code (https://github.com/cabaletta/baritone/blob/9c64067d492e3fdd7d255bdf39092524046f7121/src/main/java/baritone/pathing/movement/movements/MovementFall.java#L118) my guess is that the server doesn't update the inventory fast enough depending on ping/tps. Perhaps you could assume that unless the player is in creative, the bucket will be empty server side even if not client side, and therefore the water should be picked up.
Or perhaps when the Right Click button is set to true, we are no longer looking at the water, and therefore it fails?

## Modified settings
None

## Final checklist
- [x] I know how to properly use check boxes
- [X] I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
- [X] I have included logs, exceptions and / or steps to reproduce the issue.
- [ ] I have not used any OwO's or UwU's in this issue. <- My religion does not allow me to tick this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.