c4milo / c4milo/node-webkit-agent

Feature Request :: programmatic support for named profiles

Open
#52 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.1k
Forks
77
PR merge metrics
No merged PRs in 30d

Description

I can programmatically start and stop profiling using constructions like this:

```
agent.loadedAgents["Profiler"].start({}, () ->)
```

The v8-profiler [`startProfiling` function](https://github.com/c4milo/node-webkit-agent/blob/master/lib/v8-profiler.js#L212) supports providing a name for a profile, but the [Profiler `start` function](https://github.com/c4milo/node-webkit-agent/blob/master/lib/profiler.js#L153) doesn't provide a way to pass a name to `startProfiling`. I'd like to be able to do

```
agent.loadedAgents["Profiler"].start({name: "my-profile-name"}, () ->)
```

and have that name passed along.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.