c4milo / c4milo/gsync

Review use of sync.Pool with slices

Open
#9 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Go
Stars
384
Forks
32
PR merge metrics
No merged PRs in 30d

Description

As I known, the sync.Pool in golang , you must use get/put together. But the code below
https://github.com/c4milo/gsync/blob/master/gsync_client.go#L109

you only bufferPool.Put(bfp) when the err is io.EOF, is this ok?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.