c3js / c3js/c3

Refactoring: Do we need to support browser which doesn't have event binding function?

Open
#2,167 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.3k
Forks
1.4k
Avg merge
6d 16h
Merged PRs (30d)
1

Description

I found the code like the below.

```
if (window.attachEvent) {
// for IE
} else if (window.addEventListener) {
// for modern browsers
} else {
// for very old browsers
}
```

I think we don't need to support such old browsers that don't have either addEventListener or attachEvent.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.