bytecodealliance / bytecodealliance/wit-bindgen

Consider splitting configuration of foreign types into a new `generate!` macro config key

Open
#992 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.5k
Forks
286
Avg merge
6h 32m
Merged PRs (30d)
19

Description

In https://github.com/bytecodealliance/wit-bindgen/pull/972 the default for whether bindings would be generated for foreign (i.e., not in the same package as the target world) types was flipped from being generated by default to not. Users could still opt-into generating code for foreign types by using the `generate` keyword.

The use of a special keyword, however, might not be the most discoverable. Instead we may wish to introduce a new key in the `generate!` macro.

In short the following...

```rust
with: {
"wasi:io/poll": wasi::io::poll,
"some:package/my-interface": generate,
},
```

...would become the following...

```rust
with: {
"wasi:io/poll": wasi::io::poll,
},
generate: [
"some:package/my-interface"
]
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.