bytecodealliance / bytecodealliance/wit-bindgen

Deprecate the `async` opt?

Open
#1,623 0 comments 1 reaction 0 assignees View on GitHub
async gen-rust
Dominant language
Rust
Stars
1.5k
Forks
286
Avg merge
6h 32m
Merged PRs (30d)
19

Description

https://github.com/WebAssembly/component-model/pull/646 forbids the async canonopt with non-async functions. This makes the `async` opt to e.g. rust `generate!` look odd since "positive" overrides (like `async: true`) are always no-ops now (right?). "Negative" overrides are still meaningful but it seems like it would be less confusing for those to move to a new opt (`!async: [...]`? 🤷).

Regardless of what is done with the `async` opt in the long run it might make sense to start emitting warnings for positive overrides now, _especially_ `async: true`.

Ref https://github.com/bytecodealliance/wit-bindgen/issues/1622

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.