bytecodealliance / bytecodealliance/wasmtime

Take index type into account in dynamic memory explicit bounds checks

Open
#8,219 0 comments 0 reactions 0 assignees View on GitHub
cranelift:goal:optimize-speed
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

In [the general case](https://github.com/bytecodealliance/wasmtime/blob/6c5184809db3a92de4ee0c718c403bedc9a9ff4f/cranelift/wasm/src/code_translator/bounds_checks.rs#L258-L262), we do a bunch of `uadd_overflow_trap`s, but we shouldn't need to worry about overflow for 32-bit Wasm memories on 64-bit targets.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.