bytecodealliance / bytecodealliance/wasmtime

`connect_timeout` is used twice in wasmtime-wasi-http's outgoing handler

Open
#8,104 0 comments 0 reactions 0 assignees View on GitHub
bug wasi:impl
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

As mentioned in #8085, the `connect_timeout` is used to timeout both the initial tcp connection, and the `handshake` result from hyper. We likely only need the first timeout on the tcp connection, but it would be good to validate this.

Concretely, we can probably remove the timeout uses from these two places in `types.rs`:

https://github.com/bytecodealliance/wasmtime/blob/d27fc3d001050a93e903bb76ac5551fbc5480566/crates/wasi-http/src/types.rs#L207-L212

https://github.com/bytecodealliance/wasmtime/blob/d27fc3d001050a93e903bb76ac5551fbc5480566/crates/wasi-http/src/types.rs#L228-L234

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.