bytecodealliance / bytecodealliance/wasmtime

Fix wasmtime's caching with local development builds

Open
#6,699 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

Thought we had an issue tracking this but I guess not.

Cache entries that are stale due to local changes that have been made since the cache entry was created are reused nonetheless due to how we just check Wasmtime version (by default? I guess we have some custom version serialization stuff now, not sure how relevant it is to this)

One thing we could maybe do would be to add the hash of the whole executable to the cache key. This would be a big hammer, but would be pretty robust against any kind of local dirty state, or new commits on the same branch, or anything like that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.