bytecodealliance / bytecodealliance/wasmtime

ISLE: disallow non-partial expressions in `if` predicates

Open
#5,686 1 comment 0 reactions 0 assignees View on GitHub
isle
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

It's a footgun: they will always succeed (should be using `if-let` to match on the result of the value, not `if` on whether anything is matchable).

See #5684 where this bit us (me) in practice.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.