bytecodealliance / bytecodealliance/wasmtime

wasmtime-cache: file-per-thread-logger should be an optional dependency

Open
#3,599 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 19h
Merged PRs (30d)
121

Description

#### Feature

Make `file-per-thread-logger` an optional dependency for `wasmtime-cache`.

#### Benefit

`wasmtime-cache` pulls in `file-per-thread-logger`, which also brings `termcolor`, `regex`, and `atty`, even if you don't want to have those logs.

This is especially relevant because `cache` is a default feature of `wasmtime`.

In addition: glancing at the code it seems like the logging feature is actually never used - `Worker::start_new` is always called with `None` as the log prefix.

Is this some left-over code?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.