bytecodealliance / bytecodealliance/wasmtime

wasi-common: windows poll_oneoff implementation is poorly understood

Open
#2,880 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

The implementation of WASI `poll_oneoff` on Windows in `wasi-cap-std-sync` (and now copied in `wasi-tokio`) is poorly understood and possibly buggy. It passes the test suite, but we expect that its behavior diverges from the unix implementation in some cases. We should consider refactoring or rewriting it when time permits. This task requires some Windows programming expertise that I don't currently have.

The current implementation is one of the few pieces of pre-rewrite (#2487) wasi-common still around, originally written by @kubkon and others.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.