bytecodealliance / bytecodealliance/wasmtime

Wasmtime: Clarify the relationship between Linker and Instance

Open
#2,580 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

**The below feature description is actually already implemented, so I repurposed that issue as a documentation issue, see the second message**

#### Feature

Automatically call `_initialize` for reactors, maybe using a special function to create a reactor Module?

#### Benefit

Knowing one has to call `_initialize` is something that is not very documented (well… ok, currently nothing is very documented, but seeing as support for wasi reactors landed in rustc like two days ago it's not surprising… anyway my struggles are documented here: https://github.com/rust-lang/rust/pull/79997#issuecomment-759856446)

#### Implementation

Maybe this would be better with a separate function? But I somehow feel like calling `linker.instantiate(&module)` automatically calling `_initialize` would make sense… or maybe add a mandatory argument so people must express the choice of whether they want their module to be initialized at instantiation time or not, and at least know they have to do it manually if they want not to?

#### Alternatives

Keep the statu quo, ie. let the user call `_initialize` manually. IMO that would require much more documentation about the topic, though it's definitely a possibility too.

Thank you for all you do on wasm and the surrounding ecosystem! :heart:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.