bytecodealliance / bytecodealliance/wasmtime

[Cranelift] Add fmin / fmax variants without NaN propagation

Open
#1,906 4 comments 0 reactions 0 assignees View on GitHub
cranelift
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

This is required to correctly implement `{f32,f64}::{min,max}` in cg_clif.

Cranelift docs for `fmin` and `fmax`:

> If either operand is NaN, this returns a NaN.

libstd docs for `{f32,f64}::{min,max}`:

> If one of the arguments is NaN, then the other argument is returned.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.