bytecodealliance / bytecodealliance/wasmtime

Split up `concurrent.rs` for impoved review-ability and general tidyness

Open
#14,242 0 comments 0 reactions 0 assignees View on GitHub
wasm-proposal:component-model-async
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

Per [Alex's comment](https://github.com/bytecodealliance/wasmtime/pull/14146#discussion_r3883925549), this file has grown quite large (over 6000 lines) over time and is overdue to be split up. We could start by moving each of the `impl` blocks for e.g. `StoreContextMut`, `StoreOpaque`, `Instance`, `ConcurrentState`, etc. to their own files.

Contributor guide

Open the contributing guide

Research direction

Start with concurrent.rs, which is over 6,000 lines, and review the impl blocks for StoreContextMut, StoreOpaque, Instance, and ConcurrentState. Split those impl blocks into separate files while preserving behavior, then run the existing Wasmtime test suite to confirm the refactor is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.