bytecodealliance / bytecodealliance/wasmtime

Deduplicate more code between DRC and copying `GcCompiler` implementations

Open
#13,113 0 comments 0 reactions 0 assignees View on GitHub
wasm-proposal:gc
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

Minor comment on this and surrounding code -- this is a lot of boilerplate I suspect is more-or-less duplicated between the drc and null collector as well. It might be worth looking into at some point having various hooks into this process where a lot more of the boilerplate can be shared. For example inline allocations are probably completely different per collector but libcall-based allocations I suspect are almost exactly the same. Even calling `init.initialize(...)` and such is probably pretty similar would be my guess across collectors.

Not needed for now of course, but something that might be worth keeping in the back of our heads

_Originally posted by @alexcrichton in https://github.com/bytecodealliance/wasmtime/pull/13107#discussion_r3088544797_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.