bytecodealliance / bytecodealliance/wasmtime

wasi-http: Consider asserting that the `TE` header value can only be `trailers`

Open
#11,007 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 19h
Merged PRs (30d)
121

Description

I think @lukewagner is planning to propose this upstream for `wasi:http` but with #11002 just landed it would be good to do this sooner than later just to reduce churn across releases.

For context, we removed `TE` from the forbidden headers list partly because "it was the right thing to do" but in practice mostly because [gRPC requires it](https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md).

With [HTTP/2](https://httpwg.org/specs/rfc9113.html#rfc.section.8.2.2) and [HTTP/3](https://httpwg.org/specs/rfc9114.html#rfc.section.4.2) the only valid value for `TE` is `trailers`, so from the perspective of `wasi:http` representing an abstraction over any HTTP version it makes some sense to have this restriction.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.