bytecodealliance / bytecodealliance/wasmtime

[simplejit] Alignment constraints should be inferred from TargetMachine

Open
#1,087 5 comments 0 reactions 0 assignees View on GitHub
cranelift
Dominant language
Rust
Stars
18.6k
Forks
1.8k
Avg merge
1d 18h
Merged PRs (30d)
126

Description

Follow-up of https://github.com/CraneStation/cranelift/pull/721:

```
const EXECUTABLE_DATA_ALIGNMENT: u8 = 0x10;
const WRITABLE_DATA_ALIGNMENT: u8 = 0x8;
```

> These two numbers appear somewhat magical. Why 0x10 and 0x8? If these are meant to be target-specific, we should have TargetMachine provide them.

(Note: they might even be compiler- or OS- dependent.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.